Optimize feature registry #990
Conversation
Signed-off-by: Cai Yudong <[email protected]>
|
@cydrain 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
=========================================
+ Coverage 0 73.87% +73.87%
=========================================
Files 0 82 +82
Lines 0 6916 +6916
=========================================
+ Hits 0 5109 +5109
- Misses 0 1807 +1807 |
|
/kind improvement |
| @@ -84,7 +84,7 @@ IndexFactory::Register(const std::string& name, std::function<Index<IndexNode>(c | |||
| feature_mapping_[name] = features; | |||
| } else { | |||
| // All data types should have the same features; please try to avoid breaking this rule. | |||
| feature_mapping_[name] = feature_mapping_[name] & features; | |||
| feature_mapping_[name] |= features; | |||
There was a problem hiding this comment.
There is a problem here; if a certain data type supports a feature, then all types will be considered to support this feature; this is unreasonable.This is why ALL_TYPE is used above.
There was a problem hiding this comment.
Current feature mark mechanism cannot handle different data type support different feature for a same index type.
If it happens, the whole feature mark mechanism need be re-designed.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cydrain, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.